fix(metrics): Gracefully handle errors when recording commit status metrics#521
Open
sentry[bot] wants to merge 1 commit intomainfrom
Open
fix(metrics): Gracefully handle errors when recording commit status metrics#521sentry[bot] wants to merge 1 commit intomainfrom
sentry[bot] wants to merge 1 commit intomainfrom
Conversation
markstory
reviewed
Feb 23, 2026
Comment on lines
+276
to
+285
| try: | ||
| self.__metrics.increment( | ||
| name="arroyo.consumer.commit_status", | ||
| value=1, | ||
| tags=tags, | ||
| ) | ||
| except Exception as e: | ||
| logger.debug( | ||
| "Failed to record commit status metric: %s", e, exc_info=False | ||
| ) |
Member
There was a problem hiding this comment.
Should we consolidate the try/except and metrics.increment() call as both sides of the branch have the same logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SNUBA-9Y5. The issue was that: DatadogMetricsBackend's thread-local property corrupted during librdkafka callback exception, causing SystemError when logging metrics.
self.__metrics.incrementin the__record_commit_statusmethod withtry...exceptblocks.This fix was generated by Seer in Sentry, triggered by pierre.massat@sentry.io. 👁️ Run ID: 10536178
Not quite right? Click here to continue debugging with Seer.